Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string.gsubruns the pattern matcher at every position, even when the pattern has no special characters and can only match its own text. This adds a fast path for that case (non-anchored, non-empty patterns without special characters;)is excluded as it is still an error in a pattern):memchrfor single characters, first/last character checks beforememcmpotherwise), and the text between matches is copied at once%escapes are appended directly; other replacements go throughadd_valueas beforeThe change is behind
DFFlag::LuauOptimizeStringGsuband the flag-off branch is the original loop verbatim. Output is unchanged: a differential fuzz of 40k random calls (including error cases, replacement limits and string/table/function replacements) matches the original implementation exactly.bench/micro_tests/test_string_gsub.luaPatterns with special characters take the original path and are unaffected. Added conformance tests for patterns without special characters.