Add support for OpenTitan defined KeyLabels - #336
Merged
Merged
Conversation
willyzha
force-pushed
the
pqc-task6-ft-sival-pqc
branch
from
September 22, 2026 06:47
e9e7150 to
28a6ed3
Compare
Update ATE personalization blob unpacking, JSON commands, and ft.cc: - Inspect the ASN.1 DER X.509 TBSCertificate signature AlgorithmIdentifier OID using BoringSSL CBS and OBJ_cbs2nid() in PackX509TbsCertStruct() to populate signing algorithm parameters for NID_ecdsa_with_SHA256, NID_ML_DSA_44, and NID_ML_DSA_87, and return an error logging the OID on invalid DER or unsupported algorithms. - Add optional dice_mldsa_auth_key_key_id to CaSubjectKeysJSON proto and CaSubjectKeysToJson() to match OpenTitan manuf_certgen_inputs_t (PR #31202), omitting the field when ML-DSA DICE is disabled. - Pass kDiceMldsaCaSk to CaSubjectKeysToJson() in ft.cc and explicitly reject --enable_mldsa_dice on the pi01 SKU. - Add unit tests in ate_perso_blob_test.cc and ate_api_json_commands_test.cc. Ref: lowRISC#310 (TASK-6)
willyzha
force-pushed
the
pqc-task6-ft-sival-pqc
branch
from
September 22, 2026 06:56
28a6ed3 to
46ad90f
Compare
clundin25
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTitan repo defined key labels "PQ_UDS_44" and "PQ_UDS_87" for the PQ keys.