test,build: replace lowRISC/crt with llvm-mingw and test Win32 ATE DLL - #328
Merged
Merged
Conversation
willyzha
force-pushed
the
win32-llvm-mingw
branch
from
September 17, 2026 20:28
286d0a1 to
3411fa6
Compare
willyzha
marked this pull request as ready for review
September 17, 2026 20:55
clundin25
reviewed
Sep 18, 2026
clundin25
approved these changes
Sep 18, 2026
Replace the legacy lowRISC/crt MXE GCC 11.3.0 toolchain and its vendored Starlark rules in third_party/crt/ with llvm-mingw (Clang/LLD targeting i686-w64-mingw32-msvcrt), and add containerized Wine tests for ate.dll. Key changes: - Fix Win32 gRPC crash: GCC 11.3.0 (SJLJ exceptions) miscompiled gRPC's ServiceConfigParser::Builder::RegisterParser() at -O1/-O2, causing CreateClient() to fault with 0xC0000005. Building with llvm-mingw (DWARF unwinding) resolves this compiler bug cleanly. - Self-contained DLL: Statically link libc++, libunwind, and winpthread into ate.dll so it depends only on standard Windows OS DLLs (msvcrt.dll, KERNEL32.dll, WS2_32.dll, CRYPT32.dll). This eliminates companion MinGW runtime DLLs and allows deleting pkg_win.py and all 1,675 lines of third_party/crt/. - ABI & release hardening: Enable -mstackrealign for 32-bit MSVC/LabVIEW caller stack compatibility (4-byte vs 16-byte stack alignment) and define -DNDEBUG in non-debug builds. - Automated Wine test suite: Add a Win32 test harness (ate_dll_smoke.cc) that loads ate.dll via LoadLibrary/GetProcAddress and exercises CreateClient(), InitSession(), and CloseSession() under Wine in both unit tests (//src/ate/test_programs:ate_dll_smoke_test) and live PA integration tests (tests/run_ate_dll_test.sh).
willyzha
force-pushed
the
win32-llvm-mingw
branch
from
September 18, 2026 21:44
3411fa6 to
69d3088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the 2022 lowRISC/crt MXE GCC 11.3.0 toolchain and its vendored Starlark framework in third_party/crt/ with a standalone llvm-mingw (Clang/LLD) toolchain in third_party/llvm_mingw/, and add automated containerized Wine tests that execute the shipped Windows ATE DLL.
Why replace lowRISC/crt:
New test coverage: