Stop dev mode from dropping most of --env-file - #80
Open
vohonen wants to merge 1 commit into
Open
Conversation
`ow ssh --env-file` reads a .env and hands it to the provider, but in dev mode `start_worker` rebuilt `env` from `os.environ` using a five-var credential list, replacing whatever the caller passed. Anything outside that list never reached the pod: `WANDB_API_KEY`, `WANDB_PROJECT` and `MAX_JOBS` all vanished silently, so `--env-file` looked like it worked while delivering almost nothing. The credential list still gets forwarded from the caller's shell, but values the caller passed explicitly now survive and take precedence over the shell. Tests cover both halves, plus the operational vars set further down so they don't regress the other way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ow ssh --env-filereads a .env and hands it to the provider, but in dev modestart_workerrebuiltenvfromos.environusing a five-var credential list,replacing whatever the caller passed. Anything outside that list never reached
the pod:
WANDB_API_KEY,WANDB_PROJECTandMAX_JOBSall vanished silently,so
--env-filelooked like it worked while delivering almost nothing.The credential list still gets forwarded from the caller's shell, but values the
caller passed explicitly now survive and take precedence over the shell.
Tests cover both halves, plus the operational vars set further down so they
don't regress the other way.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com