Agent/cedar amber h7jq - #3983
Open
chemicoholic21 wants to merge 4 commits into
Open
Conversation
The host storage class syncer passed the whole *storagev1.StorageClass value to a %s verb when logging a deletion, producing an unreadable struct/pointer dump instead of the object name. Use event.Virtual.Name, matching the sibling csistoragecapacities syncer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The download-latest-cli step was downloading HTML error pages instead of the vCluster binary because curl didn't fail on HTTP errors. Added -f flag, retry logic, and an ELF binary verification check. Fixes failing upgrade-test job on PRs.
Contributor
|
I cannot accept references to github users in the code, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The download-latest-cli job in e2e.yaml and e2e-ginkgo.yaml downloaded HTML error pages instead of the vCluster binary because curl didn't fail on HTTP errors.
Changes
-fflag to curl to fail on HTTP 4xx/5xx--retry 3 --retry-delay 5for transient failures