chore(codeowners): own review routing with the eng-merge-devops team - #217
Merged
Conversation
Review routing depended on two named individuals, so whenever either was away this repo had no reachable code owner and its own merges stalled with no fallback. @loft-sh/eng-merge-devops already contains both handles plus @vcauesantos, so this widens who can sign off without moving trust to anyone new. The team holds maintain here, above the write access GitHub requires before it will resolve a team owner at all; a team without write is ignored silently and would leave the repo with no effective owner. The header comment argued for named individuals on purpose, so it is rewritten rather than left asserting the opposite of what the file now does. References DEVOPS-1309 Claude-Session: https://claude.ai/code/session_018qMu4QzV9zXGrjqDXFSm9S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Piotr1215and@sydorovdmytroin.github/CODEOWNERSwith@loft-sh/eng-merge-devops. Neither individual handle remains anywhere in the file.Review routing depended on two named individuals, so whenever either was away this repo had no reachable code owner and its own merges stalled with no fallback.
@loft-sh/eng-merge-devopsalready contains both handles plus@vcauesantos, so this widens who can sign off without moving trust to anyone new.Test plan
@loft-sh/eng-merge-devopsholdsmaintainon this repo, read fromgh api repos/loft-sh/github-actions/teams. GitHub ignores a team owner that lacks write access and leaves the repo with no effective owner, so access was confirmed before either individual handle came out..github/CODEOWNERSis the only CODEOWNERS file here; the root anddocs/paths both return 404.gh api repos/loft-sh/github-actions/codeowners/errors?ref=devops-1309/codeowners-eng-merge-devopsreturns{"errors":[]}, so the team owner resolves on this branch instead of resolving to nobody. The reviewers GitHub requests on this PR are still computed from the base branch, which is why the check runs against the ref.One of 16 sibling PRs across the org, so this one references the issue rather than closing it.
References DEVOPS-1309