You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
check_rmsmap evaluates standard deviation (stdsub) on the interpolated pixel array (rms). Interpolation acts as a low-pass filter, depressing pixel variance below the expectation (rms_expect). Consequently, stdsub frequently falls below the 1.1 * rms_expect threshold, causing varying RMS maps to be rejected and replaced with a constant (use_rms_map = False).
Fix
Subsampled the rms map and mask_arr at step increments corresponding to the evaluation grid step size (img.rms_box[1]) before computing stdsub.
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your reasoning. Why does sub-sampling avoid interpolation? Why would calculating the standard deviation on the original data cause low-pass filtering?
rms array passed to check_rmsmap is not the original data. It has been interpolated to the full image resolution via mapcoord_threaded (3rd-order spline filter). Interpolation suppresses variance.
Because the variance is lowered, stdsub drops frequently below the 1.1 * rms_expect threshold. This causes varying RMS maps to be rejected.
By sub-sampling the map at the original rms_box[1] step size, we are evaluating the standard deviation primarily on the nodes of the original coarse grid. This restores the true variance for the threshold check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_rmsmapevaluates standard deviation (stdsub) on the interpolated pixel array (rms). Interpolation acts as a low-pass filter, depressing pixel variance below the expectation (rms_expect). Consequently,stdsubfrequently falls below the1.1 * rms_expectthreshold, causing varying RMS maps to be rejected and replaced with a constant (use_rms_map = False).Fix
Subsampled the
rmsmap andmask_arrat step increments corresponding to the evaluation grid step size (img.rms_box[1]) before computingstdsub.