Skip to content

Make progressbar more universal - #430

Merged
gmloose merged 2 commits into
lofar-astron:masterfrom
AlexKurek:Make-progressbar-more-universal
Sep 7, 2026
Merged

Make progressbar more universal#430
gmloose merged 2 commits into
lofar-astron:masterfrom
AlexKurek:Make-progressbar-more-universal

Conversation

@AlexKurek

Copy link
Copy Markdown
Contributor

This makes progressbar working when no TTY is being emulated and no longer uses ANSI character cursor positioning (e.g. \x1b[1G ).

There is a chance it will fix #385.

Tested on a GNU terminal, works fine.

@gmloose gmloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments.

Comment thread bdsf/statusbar.py Outdated
Comment thread bdsf/statusbar.py
@gmloose

gmloose commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

There is a chance it will fix #385.

Not sure, there are still some places where ANSI codes are emitted. But maybe, yes.

Co-authored-by: Marcel Loose <loose@astron.nl>
@gmloose
gmloose merged commit 18fbf9b into lofar-astron:master Sep 7, 2026
1 check passed
@AlexKurek
AlexKurek deleted the Make-progressbar-more-universal branch September 7, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress bars don't work in notebooks

2 participants