Skip to content

Fix PA error calculation in gaul2srl.py - #429

Open
AlexKurek wants to merge 3 commits into
lofar-astron:masterfrom
AlexKurek:Fix-PA-error-calculation-in-gaul2srl-py
Open

Fix PA error calculation in gaul2srl.py#429
AlexKurek wants to merge 3 commits into
lofar-astron:masterfrom
AlexKurek:Fix-PA-error-calculation-in-gaul2srl-py

Conversation

@AlexKurek

Copy link
Copy Markdown
Contributor

The std must be computed in circular space in this case.

@gmloose gmloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a good improvement, but I would like @darafferty's view on this as well.

@gmloose
gmloose requested a review from darafferty September 7, 2026 11:39
@AlexKurek

Copy link
Copy Markdown
Contributor Author

@gmloose

gmloose commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Actually there also are: https://docs.astropy.org/en/latest/api/astropy.stats.circstats.circstd.html#astropy.stats.circstats.circstd and https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.circstd.html Probably better to use one of those.

Yeah, I just stumbed over the latter one. So, maybe it's indeed better to use one of those two.

@darafferty

Copy link
Copy Markdown
Collaborator

Ah yes, good find. Agreed it should be done with circular stats.

@AlexKurek

Copy link
Copy Markdown
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants