Fix invalid CDELT4 value in output FITS header - #428
Open
AlexKurek wants to merge 1 commit into
Open
Conversation
gmloose
reviewed
Sep 7, 2026
gmloose
left a comment
Collaborator
There was a problem hiding this comment.
I don't understand the reasoning. AFAIK this is a standard FITS keyword. Also I don't understand your statement in the description about the full list of FITS keywords being available. Please explain.
Contributor
Author
|
CDELT4 stores the channel size and this line hardcodes it to 300 MHz, with is not true for LOFAR not SKA (...and looks like PyBDSF was originally written for some 1.4 GHz instrument that had 300 MHz channels). I meant that we could remove this line simply, but maybe better to comment it out instead so that if somebody looks at the code - will see that CDELT keywords generally do not end at 3 ;) . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is obviously not true these days. In this case maybe better to comment it out, co that full list of FITS keyword is still there.