Skip to content

Fix invalid CDELT4 value in output FITS header - #428

Open
AlexKurek wants to merge 1 commit into
lofar-astron:masterfrom
AlexKurek:Fix-invalid-CDELT4-in-FITS-header
Open

Fix invalid CDELT4 value in output FITS header#428
AlexKurek wants to merge 1 commit into
lofar-astron:masterfrom
AlexKurek:Fix-invalid-CDELT4-in-FITS-header

Conversation

@AlexKurek

Copy link
Copy Markdown
Contributor

This is obviously not true these days. In this case maybe better to comment it out, co that full list of FITS keyword is still there.

@gmloose gmloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the reasoning. AFAIK this is a standard FITS keyword. Also I don't understand your statement in the description about the full list of FITS keywords being available. Please explain.

@AlexKurek

Copy link
Copy Markdown
Contributor Author

CDELT4 stores the channel size and this line hardcodes it to 300 MHz, with is not true for LOFAR not SKA (...and looks like PyBDSF was originally written for some 1.4 GHz instrument that had 300 MHz channels).

I meant that we could remove this line simply, but maybe better to comment it out instead so that if somebody looks at the code - will see that CDELT keywords generally do not end at 3 ;) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants