Fix flux error aggregation for multi-component sources - #395
Open
AlexKurek wants to merge 2 commits into
Open
Conversation
gmloose
reviewed
Aug 20, 2026
gmloose
left a comment
gmloose
left a comment
Collaborator
There was a problem hiding this comment.
This is probably correct, but I would like @darafferty's opinion on this too.
Collaborator
|
Yes, I think this change makes sense, but please also update the text regarding the errors in the documentation (https://github.com/lofar-astron/PyBDSF/blob/master/doc/source/algorithms.rst?plain=1#L63). |
Contributor
Author
|
thank you for pointing this out. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
totE(total flux error) in multi-Gaussian sources was underestimated. Aggregating errors in quadrature assumes independent Gaussian components, which is invalid for overlapping fits within a single island.Fix
Replaced root-sum-square addition with linear summation to account for component covariance (in the absence of a full covariance matrix).