Skip to content

Fix ptbin division in psfvary.py - #382

Open
AlexKurek wants to merge 3 commits into
lofar-astron:masterfrom
AlexKurek:Fix-ptbin-division-in-wavelets
Open

Fix ptbin division in psfvary.py#382
AlexKurek wants to merge 3 commits into
lofar-astron:masterfrom
AlexKurek:Fix-ptbin-division-in-wavelets

Conversation

@AlexKurek

@AlexKurek AlexKurek commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

In Python 3 the operator here must be //.
The test failed, but the results should be better now.

Comment thread bdsf/psf_vary.py Outdated
@gmloose
gmloose requested a review from darafferty August 24, 2026 14:37
@gmloose

gmloose commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

@darafferty, could you double check, and if you agree update the reference outputs?

@darafferty

darafferty commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Yep, I agree with the fix. I'll make an PR to update the reference files once this one is merged (or is there some way to do that in this PR?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants