Skip to content

zh-CN: sync with English source and fix accuracy issues - #454

Closed
LXD-8 wants to merge 1 commit into
lmstudio-ai:mainfrom
LXD-8:zh-CN/sync-and-review
Closed

LXD-8 wants to merge 1 commit into
lmstudio-ai:mainfrom
LXD-8:zh-CN/sync-and-review

Conversation

@LXD-8

@LXD-8 LXD-8 commented Sep 27, 2026 •

Copy link
Copy Markdown

Syncs the Simplified Chinese catalog with the current English source and fixes several accuracy problems found by reviewing every string against en/.

What changed

92 keys added (6 files) — every key that exists in en/ but not in zh-CN/:

File Keys Content
config.json 37 reasoning budget, chat template, unified KV cache, context checkpoints, MoE→CPU layer ratio, AutoFit (llama.cpp / MLX / yuzu), prompt disk cache
developer.json 17 Allow Remote MCP modes, server start/stop errors, endpoint labels
settings.json 16 navigation bar position, default context length, AutoFit minimum, JIT TTL
models.json 15 memory guardrails, not-enough-resources guidance, model source selector
chat.json 6 clear last-used model, MCP auth errors, speculative decoding stats
shared.json 1 beta

13 keys removed — the English source renamed commitChanges → saveChanges and cannotCommitChanges → cannotSaveChanges. The Chinese keys follow, with the 提交 wording updated to 保存 to match the new English (Save, not Commit). One stale key (llm.load.llama.evalBatchSize/info) no longer exists in English and was dropped.

Accuracy and consistency fixes:

  • endpoints/openaiCompatRest/title lost its {{extra}} placeholder when the English changed in Developer LM Rest API strings #314 — dynamic content silently stopped rendering. Restored.
  • 29 strings used half-width punctuation inside Chinese prose; 28 were converted to full-width, and the 29th (llm.load.llama.evalBatchSize/info) was a stale key removed together with its English source. 0 remain.
  • Two full-width colons were followed by a stray space (停止原因: {{stopReason}}).
  • Three strings rendered identical English four different ways; now unified. The XTC threshold text was also corrected — English says the tokens are removed (removes all such tokens except the least probable one), which the previous Chinese did not convey.

Reviewing against the four principles

Principle Check Result
应翻译的是否全部翻译 / 不应翻译的是否保持原文 keys present in en/ but untranslated 0 (was 92)
同上 stale keys no longer in en/ 0 (was 13)
翻译准确 {{placeholder}} parity with English 0 mismatches (was 1)
翻译准确 JSX/HTML tag parity 0 real mismatches — the 3 <Empty> → <空> cases preserve the brackets, matching ja <空>, de <Leer>, fr <Vide>
术语一致 same English source, multiple renderings 0 (was 3)
标点/格式统一 half-width punctuation in Chinese prose 0 (was 29)
格式统一 full-width colon followed by space 0
JSON validity jq empty on every changed file ✅

Intentionally left in English: Markdown, LM Studio, {{modelName}} — product names and pure placeholders.

Terminology follows the existing catalog: token with no surrounding spaces (50/50 existing occurrences), standalone acronyms KV/GPU/RAM/RoPE/MLX with spaces, 您 as the second-person pronoun (67:14 over 你), ellipsis as three half-width dots.

Verification

jq empty zh-CN/*.json                                  # validate-json ✅
added keys ⊆ en keys  (92 checked, 0 violations)        # validate-localization-keys ✅
zh-CN keys == en keys  (both directions, 0 difference)  # sync ✅

Brings the Simplified Chinese catalog back in sync with en/ and corrects
several problems found by reviewing every string against the English.

Additions (92 keys):
  - chat.json        6   clearLast-used model, MCP auth errors, speculative
                          decoding stats
  - config.json     37   reasoning budget, chat template, unified KV cache,
                          context checkpoints, MoE CPU layer ratio, AutoFit for
                          llama/MLX/yuzu, prompt disk cache, and the
                          commitChanges -> saveChanges rename
  - developer.json  17   Allow Remote MCP modes, start/stop errors, endpoint
                          labels and descriptions
  - models.json     15   memory guardrails, not-enough-resources guidance,
                          model source selector
  - settings.json   16   navigation bar position, default context length,
                          AutoFit minimum, JIT TTL
  - shared.json      1   beta

Rename (13 keys removed): the English source renamed commitChanges to
saveChanges and cannotCommitChanges to cannotSaveChanges, so the Chinese
keys followed, with 提交 wording updated to 保存 to match the new English.

Removed 1 stale key (llm.load.llama.evalBatchSize/info) that no longer
exists in the English source.

Fixes:
  - {{extra}} placeholder was dropped from endpoints/openaiCompatRest/title
    when the English changed in lmstudio-ai#314, so dynamic content stopped rendering.
  - 29 strings used half-width punctuation inside Chinese prose; converted to
    full-width (,。:) to match the rest of the catalog.
  - Two full-width colons were followed by a stray space.
  - Three strings rendered the same English source four different ways; now
    unified, and the XTC threshold text corrected to match the English — it
    says the tokens are *removed*, which the previous Chinese did not convey.

Tokens keep the catalog's existing convention of no surrounding spaces, while
standalone acronyms (KV, GPU, RAM, RoPE, MLX) keep theirs. Product names,
commands, flag names and established abbreviations stay untranslated.

Verified: all zh-CN keys match en exactly in both directions, placeholders and
JSX tags are preserved, and both repository workflows (validate-json,
validate-localization-keys) pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added the CLA signed Indicates that all contributors have signed label Sep 27, 2026
@LXD-8
LXD-8 marked this pull request as ready for review September 27, 2026 11:26
@LXD-8

LXD-8 commented Oct 12, 2026 •

Copy link
Copy Markdown
Author

@samir-lms @yagil — a friendly review request for this zh-CN catalog sync, whenever you have a moment.

Current state: MERGEABLE / CLEAN, no conflicts, CLA signed ✅ (the only check on the head is the CLA Assistant, success). No review yet.

Recap, and where to look first:

  • 92 keys added (6 files) — every key present in en/ but missing from zh-CN/: config.json 37, developer.json 17, settings.json 16, models.json 15, chat.json 6, shared.json 1.
  • 13 keys removed — the English source renamed commitChanges → saveChanges and cannotCommitChanges → cannotSaveChanges; the Chinese follows, with the old wording updated to match the new English. One stale key (llm.load.llama.evalBatchSize/info) no longer exists in English and was dropped with it.
  • One real bug fixed: endpoints/openaiCompatRest/title lost its {{extra}} placeholder when the English changed in Developer LM Rest API strings #314, so dynamic content silently stopped rendering. Restored.
  • Consistency: 29 half-width punctuation marks inside Chinese prose → 28 converted to full-width and the 29th was the stale key above (0 remain); two full-width colons followed by a stray space; three strings that rendered the same English four different ways, now unified; the XTC threshold text corrected to match English (removes all such tokens except the least probable one).
  • Checked against the four principles: untranslated keys 0 (was 92), stale keys 0 (was 13), {{placeholder}} parity 0 mismatches (was 1), JSX/HTML tag parity 0 real mismatches, same English source with multiple renderings 0 (was 3), half-width punctuation in Chinese prose 0 (was 29).

The three <Empty> → <空> cases preserve the brackets, matching ja <空>, de <Leer>, fr <Vide>. Happy to adjust any wording or scope you would prefer.

@LXD-8

LXD-8 commented Oct 14, 2026

Copy link
Copy Markdown
Author

Closing this on my side — I would rather not carry the zh-CN catalog sync through review right now. The branch is kept as-is, so it can be reopened unchanged if you would like the catalog refreshed against the current English source.


@LXD-8 LXD-8 closed this Oct 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA signed Indicates that all contributors have signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant