Repository navigation
[HIP] Port unit/launchBounds catch tests - #530
Merged
aakanksha555 merged 2 commits intoNov 6, 2026
Merged
Conversation
Copy the __launch_bounds__ Catch tests from rocm-systems. Only launch_bounds.cc is built; the other sources are compiler and hiprtc inputs. Link hiprtc and exclude nothing, matching upstream on amd_linux.
aakanksha555
requested review from
david-salinas,
kasaurov,
kzhuravl and
lamb-j
November 3, 2026 22:52
kasaurov
approved these changes
Nov 4, 2026
kasaurov
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks! The vendored files are byte-identical to rocm-systems (unchanged since our framework sync point), and SOURCES, LINK_LIBS hiprtc and the empty EXCLUDE_TESTS all match upstream: the YAML only disables two cases for amd_windows. Two small nits:
launch_bounds_compiler_error_kernels.ccandlaunch_bounds_parse_error_kernels.ccare only used by upstream's compile-error checks, which are commented out in upstream's CMakeLists.txt (stale with clang 25+), so the README comment could say they're currently unused rather than "compiler input".- Could you mention in the description what you tested it on (GPU and ROCm version)?
Upstream's compile-error checks that would consume these files are commented out, so the README should not call them compiler input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the launch_bounds Catch tests from rocm-systems. Only launch_bounds.cc is built; the other sources are compiler and hiprtc inputs. Link hiprtc and exclude nothing, matching upstream on amd_linux.
Ports
unit/launchBounds(__launch_bounds__attribute) fromprojects/hip-testsin ROCm/rocm-systems at 851d4028cb.CMakeLists.txt.launch_bounds.ccis the test, andlaunch_bounds_negative_kernels_rtc.hhis hiprtc input for its_RTCcase.launch_bounds_compiler_error_kernels.ccandlaunch_bounds_parse_error_kernels.ccare currently unused, because the upstream compile-error checks that consume them are commented out.HipCatchTestLists.cmake:SOURCES launch_bounds.cc, so the kernel input files aren't built as tests.LINK_LIBS hiprtc, matching upstream'sLINKER_LIBS.EXCLUDE_TESTS: upstream disables two cases only foramd_windowsandamd_wsl.The directory tree in
CATCH_TESTS_README.mdis updated.Tested on gfx1030 with ROCm 10.1.0:
check-hip-catch-unit-launchBoundsruns 3 test cases, all passing.Assisted-by: Claude Opus 5.5