Transition to Github Actions - #215
Merged
Merged
Conversation
Member
Author
|
@rhornung67 Just need to change the required checks, and this should be good to go. Thanks! |
rhornung67
approved these changes
Jul 23, 2026
adayton1
reviewed
Jul 23, 2026
| cmake-version: '3.29.x' # Back off version of cmake with known issue | ||
| build-dir: build | ||
| options: | ||
| CMAKE_CXX_STANDARD=20 |
Member
There was a problem hiding this comment.
Why not BLT_CXX_STD which sets CMAKE_CXX_STANDARD, CMAKE_CUDA_STANDARD and CMAKE_HIP_STANDARD (the latter two only when building with CUDA or HIP).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some design choices:
rocm6_4_3andsyclGHA jobs now use Radiuss Docker images, like RAJA.nvcc's, androcm_lateststill use images distributed from Nvidia and AMD because LLNL does not have those particular images.build_docker (target).