Expose a minimal transport-independent Rust search feature - #150
Merged
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #148
konard
marked this pull request as ready for review
August 3, 2026 10:45
Collaborator
Author
Working session summaryImplemented and finalized PR #150.
Final commit: 💰 Cost estimation:
📊 Context and tokens usage:
Total: (522.4K + 20.5M cached) input tokens, 53.5K output tokens, $28.160223 cost This summary was automatically extracted from the AI working session output. |
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (522.4K + 20.5M cached) input tokens, 53.5K output tokens, $28.160223 cost 🤖 Models used:
📎 Log file uploaded as Gist (6461KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Collaborator
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #148.
searchfeature for provider URL construction, response parsing, and caller-owned transportruntimefeature so existing consumers retain current behaviorsearch_with_transportruntime-independent and gates only the reqwest convenience implementation behindruntimebrowser-commander,reqwest, Tokio, Axum, andopenssl-sysfrom the minimal normal dependency graphRoot cause and reproduction
Every Rust dependency and module was unconditional. As a result, even consumers that only called the pure search URL/parser API selected the complete service and browser graph, including native TLS and
openssl-sys.Before the fix, the new dependency-boundary check against
--no-default-features --features searchreported:The feature-only smoke test now compiles the public URL/parser API and
search_with_transportwith a caller-owned transport. The dependency check inspects normal Cargo edges, matching what downstream applications compile while excluding test-only dependencies.Validation
cargo test --all-features(273 passed)cargo test --no-default-features --features search --test search_feature(1 passed)cargo test --no-default-featurescargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checknode scripts/rust-check-search-feature.mjsnode scripts/check-js-rust-parity.mjsnpm test -- --runInBand tests/unit/search.test.js(21 passed)npm run checkcargo package --listgit diff --checkScreenshots
Not applicable; this is a Rust feature/dependency boundary change with no visual UI impact.