Skip to content

Fix lack of write completion on disabled column. #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Aug 18, 2026
+8 −1
Merged

Fix lack of write completion on disabled column. #897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/bitcoin/database/impl/primitives/hashmaps.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,14 @@ inline typename CLASS::iterator CLASS::it(const Key& key) const NOEXCEPT
TEMPLATE
inline Link CLASS::allocate(const Link& size) NOEXCEPT
{
return body_.allocate(size);
const auto link = body_.allocate(size);

// A disabled spine is never committed, so its share of the allocation
// completes here (write completion is accounted for each column).
if (!link.is_terminal() && !enabled())
body_.complete(link, size);

return link;
}

TEMPLATE
Expand Down
Loading