Skip to content

Fix PiP not finding video in iframes/shadow DOM #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amitind wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PiP not finding video in iframes/shadow DOM #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,31 +179,35 @@ chrome.runtime.onMessage.addListener((msg, sender, sendResponse) => {
}
if (msg.type === "pip") {
chrome.scripting.executeScript({
target: { tabId: msg.tabId },
target: { tabId: msg.tabId, allFrames: true },
func: () => {
if (document.pictureInPictureElement) {
document.exitPictureInPicture();
return { action: "exited" };
}
const videos = Array.from(document.querySelectorAll("video"));
// Walk shadow roots too
const collect = (root) => {
const out = Array.from(root.querySelectorAll("video"));
root.querySelectorAll("*").forEach((el) => {
if (el.shadowRoot) out.push(...collect(el.shadowRoot));
});
return out;
};
const videos = collect(document);
if (!videos.length) return { error: "No video found on this page" };
const playing = videos.filter(v => !v.paused && !v.ended);
let video;
if (playing.length) {
video = playing.reduce((a, b) =>
(b.videoWidth * b.videoHeight) > (a.videoWidth * a.videoHeight) ? b : a
);
} else {
video = videos.reduce((a, b) =>
(b.videoWidth * b.videoHeight) > (a.videoWidth * a.videoHeight) ? b : a
);
}
const pool = playing.length ? playing : videos;
const video = pool.reduce((a, b) =>
(b.videoWidth * b.videoHeight) > (a.videoWidth * a.videoHeight) ? b : a
);
return video.requestPictureInPicture()
.then(() => ({ action: "entered" }))
.catch(e => ({ error: e.message }));
},
}).then(results => {
sendResponse(results[0]?.result || { error: "No result" });
// pick the frame that found a video
const hit = results.find(r => r.result && !r.result.error) || results[0];
sendResponse(hit?.result || { error: "No result" });
}).catch(err => {
sendResponse({ error: err.message });
});
Expand Down