Repository navigation
Normalize the serial in NewCertID so ARI replaces lookups match - #556
Merged
Merged
Conversation
ARI certIDs carry the serial as DER INTEGER value bytes, which include a leading 0x00 when the top bit is set. Issued certificates are indexed by the hex of big.Int.Bytes(), which has no such byte, so a replaces request for those certificates failed to find the original order. Fixes letsencrypt#550
mcpherrinm
requested review from
a team and
jsha
and removed request for
a team
September 23, 2026 16:00
aarongable
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550.
When a certificate's serial starts with a byte >= 0x80, ACME clients put an extra
00in front of it in the ARI certID. That's correct, since RFC 9773 asks for the DER integer bytes. But Pebble stores issued certificates under the serial without that00, so a new order withreplacesfor one of those certificates can't find the original and fails with a 500. This happens for about 1 in 256 certificates.The fix builds the certID's lookup key from the parsed number instead of the raw bytes, so both forms give the same key. This is the same way the certificate is stored in
ca.go, and the renewalInfo endpoint already looks things up this way.Testing:
00.replaces.