Repository navigation
fix(claude-channel,idle): reply hints on channel events, no idle notice before the woken target starts - #72
Merged
Conversation
…ce before the woken target starts - channel events carry reply_tool/reply_to (or reply_channel/reply_seq); instructions and tool descriptions ask the model to answer with ocs_dm/ocs_send instead of the Reply: shell line - send/dm --notify-when-idle record the wake time; an idle status unchanged since the wake is not 'done', the notice waits for a status change or a 30s grace (OCS_IDLE_WAKE_GRACE_MS)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from trying 0.9.14's
ocs claudeon a real host.reply_tool="ocs_dm" reply_to="<target>"(orreply_tool="ocs_send" reply_channel=… reply_seq=…), and the server instructions and tool descriptions ask the model to use them instead of running theReply:line in a shell.--notify-when-idlefired immediately. Right after the wake the target was still idle (not started yet), so the notice was sent at once.send/dm --notify-when-idlenow record the wake time. An idle status unchanged since the wake does not count; the notice waits for a status change, and after 30s (OCS_IDLE_WAKE_GRACE_MS) fires anyway (held, refused, or finished between polls). Standaloneocs notify-when-idleis unchanged. Protocol doc §2 updated.Verification
test/idle.test.ts(3) andtest/claude-channel.test.ts; the e2e test that encoded the old immediate notice now asserts the new behaviour. Mutation check: 5 guards flipped → red.--notify-when-idle→ no immediate notice; it arrived after the target finished (busy for 38s). For a question with no shell work, the target calledmcp__ocs__ocs_dm(found through ToolSearch). When the task itself needs a shell (sleep 8then reply), it still folded the reply into the same Bash command — a model choice, not blocked.