Skip to content

expand default permissions table to use full page width#1083

Merged
saurabhraghuvanshii merged 2 commits into
layer5io:masterfrom
areychana:fix/default-permissions-table-width
Jun 11, 2026
Merged

expand default permissions table to use full page width#1083
saurabhraghuvanshii merged 2 commits into
layer5io:masterfrom
areychana:fix/default-permissions-table-width

Conversation

@areychana

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1082

The default permissions table box was constrained to ~80% of the content column width due to the tabpane shortcode rendering inside a <ul> element, which had max-width: 80% applied by the theme.

Changes i made:

  • Wrapped the tabpane shortcode in a <div class="permissions-tabpane"> to render it outside the ul constraint
  • Added CSS to expand the tabpane to full content width
  • Centered role indicator columns (✅/❌) in the Categories tab
  • Fixed the Roles tab Description column width using table-layout: fixed with a 25/75 split

Signed commits

  • Yes, I signed my commits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request wraps the permissions tabpane in a new <div class="permissions-tabpane"> container and adds corresponding SCSS styles to format the permissions tables. The reviewer suggests refactoring the newly added SCSS rules to leverage nesting, which improves readability and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread assets/scss/_content_project.scss
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-06-11 17:54 UTC

@KatalKavya96 KatalKavya96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @areychana,

I reviewed the PR and compared it with the reported issue.
The changes look good to me:

  • The permissions tab pane is now wrapped separately so it is no longer affected by the previous list/max-width constraint
  • The table now uses the page width much better
  • The role indicator columns in the Categories tab are visually cleaner after being centred
  • The Roles tab also looks improved with the fixed table layout and better Description column width
  • The follow up SCSS nesting refactor also makes the styling cleaner and easier to maintain

I checked the preview behaviour and the table now makes much better use of the available horizontal space while keeping the content readable

Looks good to me!

@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@areychana Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@hortison hortison requested a review from Bhumikagarggg June 11, 2026 03:19
@hortison

Copy link
Copy Markdown
Contributor

@Bhumikagarggg review this. collaborate with the author until it is merged.

@Bhumikagarggg Bhumikagarggg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

The top section appears to be cut off. The "Categories" and "Roles" tabs are partially hidden/clipped at the top, which affects the UI layout and visibility.

@areychana

Copy link
Copy Markdown
Contributor Author

Image The top section appears to be cut off. The "Categories" and "Roles" tabs are partially hidden/clipped at the top, which affects the UI layout and visibility.

Hi @Bhumikagarggg thanks for the review! i have applied your suggestion and pushed the fix. pls take another look when you get a chance! :)

Signed-off-by: areychana <93970069+areychana@users.noreply.github.com>

@Bhumikagarggg Bhumikagarggg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thanks @areychana

@areychana areychana force-pushed the fix/default-permissions-table-width branch from e9da455 to 0669f0e Compare June 11, 2026 17:45
@areychana

Copy link
Copy Markdown
Contributor Author

LGTM 🚀 Thanks @areychana

i have squashed all commits into one clean commit and force pushed. its ready for merge whenever a maintainer is available!!

@saurabhraghuvanshii saurabhraghuvanshii merged commit ae20683 into layer5io:master Jun 11, 2026
1 check passed
@welcome

welcome Bot commented Jun 11, 2026

Copy link
Copy Markdown

        Thank you for contributing to the Layer5 community! 🎉 \ \ Congrats! \ \         ⭐ Please leave a star on the project. 😄

@areychana areychana deleted the fix/default-permissions-table-width branch June 11, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Permissions Table: Improve use of space on the page

5 participants