fix(ci): validate static workflow identity - #2015
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughWorkflow-run validation in both review jobs now resolves the workflow from ChangesWorkflow identity validation
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1abebabab4a09b4aef5827ffbceacdcaf2af5403🧩 Skill updatenpx skills add larksuite/cli#fix/semantic-review-workflow-name -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
=======================================
Coverage ? 75.16%
=======================================
Files ? 912
Lines ? 96451
Branches ? 0
=======================================
Hits ? 72495
Misses ? 18380
Partials ? 5576 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fix Semantic Review failures after CI adopted the dynamic
CI / <PR number>run name. Workflow identity is now verified from the static Actions workflow metadata while preserving the existing fail-closed repository, event, path, and SHA checks.Changes
workflow_idin both the PR quality summary and semantic review jobs.workflow_run.namefrom being reused as workflow identity.Test Plan
make script-test(150 tests)make unit-testgo vet ./...gofmt -l .produces no outputgo mod tidyleavesgo.modandgo.sumunchangedgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/mainreports 0 issuesRelated Issues
Summary by CodeRabbit