Repository navigation
fix(box): allow nsjail to clean up cgroups on timeout - #190
Merged
Merged
Conversation
Reuse graceful termination before escalating to SIGKILL so nsjail can reap child processes and remove their cgroups. Add regression coverage for timeout and cancellation cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timed-out nsjail executions previously killed the supervisor immediately, leaving empty cgroup directories behind. Reuse the existing termination helper to send SIGTERM and allow child reaping and cgroup cleanup, escalating to SIGKILL after two seconds if necessary. Timeout result semantics remain unchanged.
Extend regression coverage to verify graceful termination for both timeouts and cancellation.
Validation