Repository navigation
LANG-137: Skip event RPC for plugins without EventListener - #186
Merged
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LANG-137
Tracking: LANG-137, child of LANG-131.
Changes
Listener dispatch remains serial, with trusted identity, filtering and failure semantics. SDK #183 already upstream; not resubmitted.
Already upstream
Core #2706/#2718/#2725 and SDK #183 remain untouched. Summary transaction and explicit selected-path export protocol preserved.
Tests
20 passed;
sdk-final.log.ation/
class BaseEventModel(WorkspaceExecutionScope):
scratch/sdk-admission/src/langbot_plugin/runtime/plugin/container.py:29
/home/rock/multica_workspaces/langbot-app-edb069796238/lang-131-daf85ff93baf/workdir/scratch/sdk-admission/src/langbot_plugin/runtime/plugin/container.py:29: PydanticDeprecatedSince20: Support for class-based
configis deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.12/migration/class PluginContainer(pydantic.BaseModel):
scratch/sdk-admission/src/langbot_plugin/runtime/plugin/container.py:100
/home/rock/multica_workspaces/langbot-app-edb069796238/lang-131-daf85ff93baf/workdir/scratch/sdk-admission/src/langbot_plugin/runtime/plugin/container.py:100: PydanticDeprecatedSince20: Support for class-based
configis deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.12/migration/class ComponentContainer(pydantic.BaseModel):
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
20 passed, 48 deselected, 9 warnings in 0.58s
Risks
Listener dispatch remains serial, with trusted identity, filtering and failure semantics. SDK #183 already upstream; not resubmitted.
No actual Docker, real-model, deployment or release validation; no CI wait.
Reproduce focused checks
PYTHONPATH=src python -m pytest tests/runtime/plugin/test_manager.py -k "emit_event or listener or subscriber_failures" -qEarly restricted-sandbox runs used an external polling-loop harness for thread wakeups; final busy/SDK/LocalAgent regressions ran without that harness after network was enabled.