Repository navigation
fix(box): fix shared artifact mounts and host process cleanup - #183
Merged
Merged
Conversation
Reuse box.local.host_root for Docker/Podman artifact caches so containerized Box works with existing same-path bind mounts. Add regression tests and Docker socket acceptance CI.
Check process-group liveness independently of shell exit and send SIGKILL after the grace period when descendants ignore SIGTERM. Add timeout and cancellation regressions for closed output pipes and an exited parent shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Containerized Box creates artifact caches in its private
/tmp, so the host Docker daemon cannot resolve their bind-mount sources. Place Docker/Podman caches under the existingbox.local.host_rootto work with existing same-path Compose mounts, while preserving read-only artifacts and session cleanup.Host timeout/cancellation cleanup now waits for the original process group rather than treating shell exit as completion. Surviving descendants receive SIGKILL after the existing two-second grace period, including when the shell has already exited or descendants close their output pipes.
Add regression coverage and a real Docker socket acceptance workflow that runs on
mainpushes or manual dispatch using a GitHub-hosted Ubuntu runner.Validation