feat(spec-sync): concise PR overview, generated title, skip specs in Copilot review - #141
Merged
Merged
Conversation
…Copilot review - Rewrite the "What changed" prompt to the concise GitHub "Pull request overview" style: one lead sentence + a short **Changes:** bullet list (no resource sub-headers, no long parentheticals). - Generate a PR title from the diff and set it via the same REST PATCH. The workflow passes the static "spec-sync(v1|v2)" prefix; the LLM writes only the summary suffix. Best-effort — the static title stands on failure. - Tell Copilot code review to skip the spec snapshot files entirely (specs/*.json, specs/_generated/) — they mirror the upstream spec, fetched live and regenerated each sync, so spec issues belong upstream. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates automated spec-sync PR authoring and review guidance.
Changes:
- Produces concise PR summaries and generated titles.
- Passes V1/V2 title prefixes through the workflow.
- Instructs Copilot to skip generated spec snapshots.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/spec-sync/summarize-pr.sh |
Generates concise summaries and title suffixes. |
.github/workflows/spec-sync.yml |
Configures V1/V2 title prefixes. |
.github/copilot-instructions.md |
Adds snapshot review exclusions. |
- Description prompt: add a no-surface-change escape hatch so a mechanical-only snapshot PR emits a single "no SDK changes" sentence instead of being forced to invent 2-5 bullets. - Copilot instructions: the snapshot skip was phrased as a "review only src/tests/docs" allowlist, which also dropped api.md/README.md — the exact hand-maintained surface docs the wiring commit updates. Reframe as a denylist that skips only the spec snapshots and explicitly keeps those in scope. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
scripts/spec-sync/summarize-pr.sh:89
- The advertised 60-character suffix limit is only a prompt instruction; the enforced cap is applied after adding the prefix and still permits a suffix of roughly 105 characters for the configured prefixes. Since model output is untrusted and may ignore prompt constraints, enforce the suffix limit before composing the title so generated PR titles remain concise.
title="${title:0:120}"
yzld2002
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tweaks to the spec-sync PR-authoring, from review feedback on #140.
1. Concise "What changed". The
summarize-pr.shprompt now produces the GitHub "Pull request overview" shape — one lead sentence + a short**Changes:**bullet list — instead of the verbose, resource-grouped output. No sub-headers, no long parentheticals.2. Generated PR title. A second small LLM call writes a title summary, set via the same REST
PATCHthat updates the body. The workflow passes the static prefixspec-sync(v1)/spec-sync(v2); the model writes only the suffix, e.g.spec-sync(v2): document DPT-3 Fast and presigned-URL validity. Best-effort — the static title stands on failure, andthinking:{type:"disabled"}keeps it cheap/deterministic like the body call.3. Copilot skips the spec snapshots.
copilot-instructions.mdnow tells Copilot code review to skipspecs/*.jsonandspecs/_generated/entirely (no comments at all) — they mirror the upstream OpenAPI spec (fetched live, regenerated each sync) and cannot be fixed here; spec issues belong upstream.Note: a hard guarantee (repo Settings → Copilot → Content exclusion →
specs/**) is UI-only and out of scope for this PR; this is the committable soft rule.