Skip to content

fix: suppress emoji in minikube addons list when MINIKUBE_IN_STYLE=false#23025

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-minikube-emojis-suppression
Draft

fix: suppress emoji in minikube addons list when MINIKUBE_IN_STYLE=false#23025
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-minikube-emojis-suppression

Conversation

Copilot AI commented May 22, 2026

Copy link
Copy Markdown
Contributor

MINIKUBE_IN_STYLE=false did not suppress the ✅ emoji in minikube addons list because iconFromStatus hardcoded the emoji without consulting the style setting.

Changes

  • pkg/minikube/out/out.go: Add exported IsStyleEnabled() to expose the internal useColor state (already driven by MINIKUBE_IN_STYLE)
  • cmd/minikube/cmd/config/addons_list.go: Gate the ✅ emoji in iconFromStatus behind out.IsStyleEnabled()

Before (MINIKUBE_IN_STYLE=false):

│ default-storageclass  │ minikube │ enabled ✅ │ Kubernetes │

After (MINIKUBE_IN_STYLE=false):

│ default-storageclass  │ minikube │ enabled    │ Kubernetes │

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2026
Copilot AI linked an issue May 22, 2026 that may be closed by this pull request
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @Copilot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2026
@minikube-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from medyagh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Fix emojis and icons emission in minikube commands fix: suppress emoji in minikube addons list when MINIKUBE_IN_STYLE=false May 22, 2026
Copilot AI requested a review from medyagh May 22, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MINIKUBE_IN_STYLE=false should supress emojis and icons everywhere

4 participants