fix: suppress emoji in minikube addons list when MINIKUBE_IN_STYLE=false#23025
fix: suppress emoji in minikube addons list when MINIKUBE_IN_STYLE=false#23025Copilot wants to merge 2 commits into
minikube addons list when MINIKUBE_IN_STYLE=false#23025Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
minikube addons list when MINIKUBE_IN_STYLE=false
MINIKUBE_IN_STYLE=falsedid not suppress the ✅ emoji inminikube addons listbecauseiconFromStatushardcoded the emoji without consulting the style setting.Changes
pkg/minikube/out/out.go: Add exportedIsStyleEnabled()to expose the internaluseColorstate (already driven byMINIKUBE_IN_STYLE)cmd/minikube/cmd/config/addons_list.go: Gate the ✅ emoji iniconFromStatusbehindout.IsStyleEnabled()Before (
MINIKUBE_IN_STYLE=false):After (
MINIKUBE_IN_STYLE=false):