Repository navigation
docs: Document sidecarContainers for Fluent Bit - #352
Draft
promptless-for-oss wants to merge 1 commit into
Draft
promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Documents the new
sidecarContainersfield on the Fluent Bit spec, added in kube-logging/logging-operator#2359. Fluentd has supported user-defined sidecars since 4.5. Until now, the Fluent Bit DaemonSet ran only the containers the operator manages.Changes:
logging-infrastructure/fluentbit.md: a new Sidecar containers section. It explains what the field is for, using the issue's example of a sidecar that restarts a Fluent Bit that has stopped shipping logs. It also covers where the operator places these containers in the DaemonSet pod, the names to avoid, and that the field works in bothFluentbitAgentandlogging.spec.fluentbit. A minimal example follows.whats-new/_index.md: a bullet under## Unreleased, the same heading other open What's new suggestions use. Rename it to the release version when this ships.The section links to
fluentbit_types.md#fluentbitspec-sidecarcontainerswithrelref. That anchor appears in the next generated-docs sync from the operator repository. Until then, the link opens the reference page without jumping to the field. The generated reference page wasn't edited by hand.Verification: the site builds with Hugo 0.110.0 extended, the version CI uses, and both new links resolve.
Merge after kube-logging/logging-operator#2359 merges. You can tell it has merged when the PR shows as merged on GitHub.
Trigger Events