Draft
Add SpriteBatch Draw/DrawString overloads accepting Pose2#2609
Conversation
Agent-Logs-Url: https://github.com/kniEngine/kni/sessions/7cf68c6c-3cc3-461f-b130-539059ab9846 Co-authored-by: nkast <3018589+nkast@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
nkast
April 24, 2026 18:44
View session
Contributor
|
I don't know if that would be helpful or add more noise to Spritebatch. It was more of a test to see what Claude could do. |
Contributor
|
@copilot do you think we need all of those? |
Contributor
Author
Not strictly — here's the breakdown by value:
If the goal is minimal added surface, keeping just the first two ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpriteBatchhad no overloads acceptingPose2, requiring callers to manually decompose it intoposition+rotationat every call site.Changes
SpriteBatch.Draw— new overload replacingVector2 position+Complex rotationwith a singlePose2 pose:SpriteBatch.DrawString— three new overloads (mirroring existingComplexvariants) forstring,StringBuilder, andStringBuilder+ RTL:All overloads delegate to their corresponding
Complexcounterparts viapose.Translationandpose.Orientation.