Skip to content

Use official secretreader plugin#2306

Merged
knative-prow[bot] merged 4 commits into
knative:mainfrom
kahirokunn:secretreader-access-provider
Jun 10, 2026
Merged

Use official secretreader plugin#2306
knative-prow[bot] merged 4 commits into
knative:mainfrom
kahirokunn:secretreader-access-provider

Conversation

@kahirokunn

Copy link
Copy Markdown
Member

Fixes #

Background

The multicluster e2e setup previously built and used a test-only exec credential plugin because the official Cluster Inventory API access provider plugins were not available yet. The official secretreader and kubeconfig-secretreader plugin images have now been released, so this PR switches the examples and tests to use those published images directly.

Proposed Changes

  • Switch the multicluster access provider examples and e2e setup from the test-only self-built exec plugin to the official Cluster Inventory API secretreader plugin images.

Release Note

Multicluster access provider examples and e2e setup now use the official Cluster Inventory API secretreader plugin images.

@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2026
@knative-prow knative-prow Bot requested review from aliok and houshengbo May 28, 2026 02:21
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (1412e95) to head (d571c3d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          55       55           
  Lines        2478     2478           
=======================================
  Hits         1582     1582           
  Misses        777      777           
  Partials      119      119           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn force-pushed the secretreader-access-provider branch from 765cc14 to d571c3d Compare June 10, 2026 04:51
@kahirokunn

Copy link
Copy Markdown
Member Author

/retest

@kahirokunn

Copy link
Copy Markdown
Member Author

/test serving-upgrade-tests

@kahirokunn

Copy link
Copy Markdown
Member Author

/test upgrade-tests

@houshengbo houshengbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2026
@knative-prow

knative-prow Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2026
@knative-prow knative-prow Bot merged commit 6b0f9d8 into knative:main Jun 10, 2026
26 checks passed
@kahirokunn

Copy link
Copy Markdown
Member Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants