Repository navigation
Fixed: Content drawer dialog was showing in branded apps when it is disabled. - #5234
Merged
Merged
Conversation
…isabled. * Now, we are only showing this TOC drawer hint if the TOC sidebar is enabled for branded apps. * Added necessary comments for devs.
harshsomankar123-tech
requested changes
Oct 27, 2026
harshsomankar123-tech
left a comment
Collaborator
There was a problem hiding this comment.
@MohitMaliFtechiz Thanks for the PR!
Instead of overriding in BrandedReaderViewModel, can we handle this directly in CoreReaderViewModel???
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
============================================
- Coverage 80.28% 80.24% -0.04%
Complexity 2575 2575
============================================
Files 377 377
Lines 19788 19793 +5
Branches 2395 2395
============================================
- Hits 15886 15883 -3
- Misses 2832 2836 +4
- Partials 1070 1074 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harshsomankar123-tech
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5233