Skip to content

Fixed: Content drawer dialog was showing in branded apps when it is disabled. - #5234

Merged
kelson42 merged 2 commits into
mainfrom
Fixes#5233
Oct 27, 2026
Merged

kelson42 merged 2 commits into
mainfrom
Fixes#5233

Conversation

@MohitMaliFtechiz

Copy link
Copy Markdown
Collaborator

Fixes #5233

  • Now, we are only showing this TOC drawer hint if the TOC sidebar is enabled for branded apps.
  • Added necessary comments for devs.

…isabled.

* Now, we are only showing this TOC drawer hint if the TOC sidebar is enabled for branded apps.
* Added necessary comments for devs.

@harshsomankar123-tech harshsomankar123-tech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitMaliFtechiz Thanks for the PR!
Instead of overriding in BrandedReaderViewModel, can we handle this directly in CoreReaderViewModel???

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.24%. Comparing base (002331c) to head (13e69e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../kiwixmobile/custom/main/BrandedReaderViewModel.kt 0.00% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5234      +/-   ##
============================================
- Coverage     80.28%   80.24%   -0.04%     
  Complexity     2575     2575              
============================================
  Files           377      377              
  Lines         19788    19793       +5     
  Branches       2395     2395              
============================================
- Hits          15886    15883       -3     
- Misses         2832     2836       +4     
- Partials       1070     1074       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42
kelson42 merged commit 8fd5b93 into main Oct 27, 2026
31 of 35 checks passed
@kelson42
kelson42 deleted the Fixes#5233 branch October 27, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content drawer hint dialog should not show when the TOC drawer is disabled in branded apps.

4 participants