Skip to content

Improved Book Title Style - #5232

Merged
kelson42 merged 1 commit into
kiwix:mainfrom
atharvyadav22:ui/bookTitle
Oct 27, 2026
Merged

kelson42 merged 1 commit into
kiwix:mainfrom
atharvyadav22:ui/bookTitle

Conversation

@atharvyadav22

Copy link
Copy Markdown
Collaborator

Fixes: #5204

  • Created an reusable function to make code base cleaner

Screenshots

Light Dark
Image Image

@atharvyadav22
atharvyadav22 marked this pull request as ready for review October 26, 2026 11:52
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.28%. Comparing base (90d041c) to head (002331c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/java/org/kiwix/kiwixmobile/ui/BookItem.kt 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5232      +/-   ##
============================================
+ Coverage     80.14%   80.28%   +0.13%     
- Complexity     2573     2575       +2     
============================================
  Files           377      377              
  Lines         19781    19788       +7     
  Branches       2395     2395              
============================================
+ Hits          15853    15886      +33     
+ Misses         2859     2832      -27     
- Partials       1069     1070       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42

Copy link
Copy Markdown
Collaborator

lgtm!

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atharvyadav22 Thank you. LGTM.

@kelson42
kelson42 merged commit 66837be into kiwix:main Oct 27, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library book title not "strong" enough

3 participants