feat(mac): add support for legacy kmp.inf packages 🍎 - #16551
Open
sgschantz wants to merge 8 commits into
Open
Conversation
basing on Objective C code added default for readMe and Help files added validation for required fields
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
Bot
changed the title
8 tasks
get graphic file name from correct location improved handling of parse error bounds check for value array on website url
Contributor
Author
|
@mcdurdin, do you know any good packages to test this with? The only ones I have found could not be loaded for other reasons apart from reading the kmp.inf. I'd like to test with something official instead of just keyboard packages where I removed the kmp.inf. |
sgschantz
marked this pull request as ready for review
September 11, 2026 18:19
…into feat/mac/kmp-inf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a kmp.json file cannot be found within a package, read the kmp.inf file and use it to load the file rather than throwing an error.
Fixes: #16485
Build-bot: release:mac
Test-bot: skip