fix(windows): add manual check arg to handlecheck - #16550
Open
rc-swag wants to merge 2 commits into
Open
Conversation
Adds a manual check argument to handlecheck which is now also added to RemoteUpdateCheck. Previously HandleCheck events in the statemachine was considered to be a manual check, versus via HandleKmShell where auto checks via boot, via kmshell starting Keyman for the first time in a session. However, the HandleCheck event is called when kmshell is run using the -buc command which is used by an external time scheduled event. In the current case it is a timer in the main Keyman app. Fixes: #15419
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
mcdurdin
approved these changes
Sep 11, 2026
Member
Yes, we could test this with a local api.keyman.com with a minor tweak to /script/windows/14.0/update/index.php to log the request to a temp file on the server, something like: file_put_contents('/tmp/req', print_r($_REQUEST, true));Run the test, then check the temp file through Docker to see if the right parameters were passed in. This may be outside a normal user test scope though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a manual check argument to handlecheck which is now also added to RemoteUpdateCheck. Previously a HandleCheck event in the statemachine was considered to be a manual check, versus via HandleKmShell were auto checks via boot or via kmshell starting Keyman for the first time in a session. However, the HandleCheck event is called when kmshell is run using the
-buccommand line switch which is used by an external time scheduled event. In the current case it is a timer in the main Keyman app.Fixes: #15419
@mcdurdin is there a way to have manual test case for this. e.g. finding the request on the server side. Or setting up a local server?