Skip to content

bug: some RewriteRules include unnecessary globs for query string #361

Description

@mcdurdin

For example, the following rule has a trailing .*, but query string is not included in the URL during match in mod_rewrite, so this can be eliminated. The trailing .* is messy and wrong -- we don't want to match any other paths other than .../update itself.

api.keyman.com/.htaccess

Lines 121 to 122 in 2c6473a

# developer/14.0+/update
RewriteRule "^developer/[1-9][0-9]\.[0-9]/update(.*)" "/script/developer/14.0/update/index.php$1" [END]

For example:

# developer/14.0+/update
RewriteRule "^developer/[1-9][0-9]\.[0-9]/update(.*)" "/script/developer/14.0/update/index.php$1" [END]

Should simplify to:

# developer/14.0+/update
RewriteRule "^developer/[1-9][0-9]\.[0-9]/update$" "/script/developer/14.0/update/index.php" [END]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcommon/

    Type

    Projects

    • Status
      Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions