Fix undefined references in various places - #235
Open
zapu wants to merge 5 commits into
Open
Conversation
zapu
commented
Jul 31, 2026
|
|
||
| add_priv : (priv_raw) -> | ||
| [err, @priv, len] = Priv.alloc priv_raw | ||
| [err, len] |
Contributor
Author
There was a problem hiding this comment.
unused, I couldn't figure out how that was supposed to work. Priv.alloc does not return array of 3 elements anywhere.
zapu
commented
Jul 31, 2026
| fn = (buf) -> obj.finalize(WordArray.from_buffer(buf)).to_buffer() | ||
| fn.algname = buf.algname | ||
|
|
||
| #==================================================================== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a few missing imports and other typos that would cause ReferenceError. This is especially dangerous in async context in iced code, where in a Node.js environment it would crash the process with an "uncaught exception" error. The P3SKB decryption error here is an example of such issue, where calling (async)
KeyManager.import_from_p3skbwith a corrupted bundle throws ReferenceError.