feat: allow secretRef for admin password, token, and s3 credentials#81
Open
mladedav wants to merge 1 commit into
Open
feat: allow secretRef for admin password, token, and s3 credentials#81mladedav wants to merge 1 commit into
mladedav wants to merge 1 commit into
Conversation
Member
|
Thanks! Very welcome addition. Two small things before merge:
|
Author
|
I've bumped the version and added the docs. There was no section for s3 though so I've created one. I didn't fill it with all options, just the new ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we have to either have the secrets in plaintext in
values.yamlor we have to use `extraEnvVars workaround like this:This allows to set the secretRef for admin password and token and for s3 credentials in the same way as can be done for oauth2 secret and cookie signing secret.