fix: change recycle strategy for pooled connections - #60
Draft
aeveris wants to merge 2 commits into
Draft
Conversation
Iizuki
self-requested a review
July 11, 2026 11:39
Iizuki
marked this pull request as ready for review
July 11, 2026 11:40
Iizuki
marked this pull request as draft
July 11, 2026 11:40
Iizuki
reviewed
Jul 11, 2026
Comment on lines
+107
to
+118
| client | ||
| .ldap | ||
| .simple_bind(&*self.config.bind_dn, &*self.config.bind_password) | ||
| .await | ||
| .map_err(|e| Self::Error::Connection("simple bind attempt failed".into(), e))? | ||
| .success() | ||
| .map_err(|e| Self::Error::Connection("simple bind returned an error".into(), e))?; | ||
| if client.ldap.is_closed() { | ||
| Err(RecycleError::message("ldap connection is closed")) | ||
| } else { | ||
| Ok(()) | ||
| } |
Collaborator
There was a problem hiding this comment.
Once #61 is fixed it should be enough to just do the is_closed() check here.
Collaborator
There was a problem hiding this comment.
It's done now. Merging/rebasing from main and simplifying this should do the trick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to reset pooled connections to their initial state when they get recycled by (re)binding with the user and password given in the config.
closes #58