Skip to content

fix: address save-to-device review findings - #2

Merged
junkerderprovinz merged 1 commit into
junkerderprovinz:feat/save-to-device-folderfrom
zerox80:fix/save-to-device-review-followups
Aug 12, 2026
Merged

fix: address save-to-device review findings#2
junkerderprovinz merged 1 commit into
junkerderprovinz:feat/save-to-device-folderfrom
zerox80:fix/save-to-device-review-followups

Conversation

@zerox80

@zerox80 zerox80 commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • keep export downloads isolated from the shared local cache and Room state
  • retry temporary network and server failures without deleting the persisted export job
  • persist descendant checkpoints so large selected folders resume where they stopped
  • update the export-job Room schema and the affected view-model test setup

Why

Follow-up to the review of opencloud-eu#206. This prevents cache races, preserves retry state, and avoids restarting a large folder from its first child.

Checks

  • static diff and schema inspection
  • tests and build not run, per repository instruction

@zerox80
zerox80 marked this pull request as ready for review August 12, 2026 21:43
@zerox80

zerox80 commented Aug 12, 2026

Copy link
Copy Markdown
Author

@junkerderprovinz pls merge this then its Merge-Ready.

@junkerderprovinz
junkerderprovinz merged commit 7f6b202 into junkerderprovinz:feat/save-to-device-folder Aug 12, 2026
1 check passed
@junkerderprovinz

Copy link
Copy Markdown
Owner

Thanks for this - the export-isolation + retry-checkpoint work is exactly what was needed after the opencloud-eu#206 review. Appreciate the follow-through on both rounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants