Skip to content

chore: migrate to @sethfalco/eslint-config - #80

Merged
SethFalco merged 1 commit into
jsonresume:mainfrom
SethFalco:eslint
Feb 22, 2026
Merged

SethFalco merged 1 commit into
jsonresume:mainfrom
SethFalco:eslint

Conversation

@SethFalco

@SethFalco SethFalco commented Feb 22, 2026 •

Copy link
Copy Markdown
Member

Just migrates the ESLint config from being defined directly from within this project to a @sethfalco/eslint-config package which centralized the config across all projects I maintain.

Summary by CodeRabbit

  • Chores
    • Updated ESLint configuration to use an external preset, simplifying setup
    • Configured npm registry for scoped package dependencies
    • Updated development dependencies, including new ESLint configuration package
    • Minor JSDoc formatting cleanup

Just migrates the ESLint config from being defined directly from within
this project to a @sethfalco/eslint-config package which centralized the
config across all projects I maintain.
@coderabbitai

coderabbitai Bot commented Feb 22, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


Walkthrough

Configuration updates introducing a scoped npm registry for the sethfalco scope in .yarnrc.yml, migrating ESLint configuration to use an external preset package via eslint.config.mjs, and updating package.json dependencies to reflect the new ESLint configuration source.

Changes

Cohort / File(s) Summary
Registry & Dependency Configuration
.yarnrc.yml, package.json
Added scoped npm registry override for sethfalco scope pointing to GitLab registry; replaced @eslint/js with @sethfalco/eslint-config and removed eslint-plugin-import and globals from devDependencies.
ESLint Configuration
eslint.config.mjs
Refactored default export to use external teapartyConfig preset instead of inline array of ESLint configuration objects; reduced file from 53 to 2 lines.
Minor Cleanup
pa11y.js, src/index.js
Removed stray comment/asterisk lines from JSDoc blocks; purely formatting adjustments with no functional impact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A scoped registry hops into place,
ESLint config wears a new face,
External preset, lean and bright,
Dependencies align just right!
Clean slate, clean scope, what a race! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: migrating the ESLint configuration to an external package (@sethfalco/eslint-config), which is the primary purpose reflected in the file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SethFalco
SethFalco merged commit 9b0a588 into jsonresume:main Feb 22, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant