Repository navigation
Fix PDF previews for Windows extended-length paths - #525
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows vault paths canonicalized by Rust use the extended-length prefix
\\?\. The preview URL builder treated its?as the start of a URL query, truncated the file path, and rejected PDFs inside the vault as being outside it before PDF.js could load them.Preserve the Windows namespace when splitting URL suffixes, including extended UNC paths and forward-slash equivalents. Add regression coverage for PDF loading, preview authorization, generated image URLs, and files outside the vault.
Include a standalone integration suite that compiles a small Rust canonicalization helper, reads a generated PDF through the real preview handler, and loads its page operators with PDF.js. Run it with
npx vitest run --config scripts/pdf-windows-paths.vitest.config.tsfromapps/desktopwith Rust installed. The OneDrive-like test directory is local; it does not exercise cloud synchronization.Validation:
Related to #519.