Repository navigation
fix(deps): patch source-map-js and Mermaid KaTeX - #521
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web clipper locked vulnerable
source-map-js@1.2.1, and Mermaid bundledkatex@0.16.47even though the desktop editor already used patched KaTeX. Pin source-map-js to 1.2.2 through the existing pnpm workspace overrides and make Mermaid reuse the desktop KaTeX dependency (currently locked at 0.18.2), removing the vulnerable nested copy.Addresses Dependabot alerts #145 and #143. Upstream advisories: source-map-js and KaTeX.
Validation:
npm@11 ci) and frozen clipper install (pnpm@10.33.0 install --frozen-lockfile) passed.pnpm run check: TypeScript, 25 tests, and Chrome/Firefox builds passed.npm run lintandnpm run buildpassed.--maxWorkers=2passed all 42 tests across UnifiedBar, Mermaid renderer, block previews, and Mermaid file preview.trustcannot enable JavaScript links or external images, while ordinary fractions still render.The Mermaid override crosses its declared KaTeX minor-version range; the real formula rendering smoke and desktop build cover this compatibility concern.