Skip to content

Fix MLIR interfaces to preserve attr/type trait metadata in ODS - #176

Merged
jonathanvdc merged 5 commits into
mainfrom
copilot/fix-mlir-type-attr-trait-metadata
Apr 23, 2026
Merged

Fix MLIR interfaces to preserve attr/type trait metadata in ODS#176
jonathanvdc merged 5 commits into
mainfrom
copilot/fix-mlir-type-attr-trait-metadata

Conversation

Copilot AI commented Apr 23, 2026 •
edited by jonathanvdc
Loading

Copy link
Copy Markdown
Contributor
  • Add InterfaceKind, InterfaceMethodKind enums
  • Add InterfaceMethodModel, InterfaceModel classes
  • Add InterfaceTraitModel to TraitModel.cs
  • Add Traits to TypeModel and AttributeModel
  • Add Interfaces to DialectModel / DialectModelBuilder
  • Update OdsRecordIndex to classify interface-backed traits (named records and AnonymousRecordValue)
  • Handle DeclareXxxInterfaceMethods inline instantiations in TryBuildTraitModel
  • Update TypeRecordImporter and AttributeRecordImporter to import traits
  • Add InterfaceRecordImporter + wire into DialectImporter
  • Add issue Model MLIR interfaces and preserve attr/type trait metadata in ODS #152 importer tests (all 39 pass, 222 total pass)
  • Implement issue Generate C# marker interfaces for MLIR type interfaces #153: generate C# marker interfaces for TypeInterface records
  • Add TypeEmitter changes to emit marker interfaces and attach to type classes
  • Add issue Generate C# marker interfaces for MLIR type interfaces #153 generator tests
  • All tests passing

Copilot AI linked an issue Apr 23, 2026 that may be closed by this pull request
Model MLIR interfaces and preserve attr/type trait metadata in ODS #152
Closed
@jonathanvdc jonathanvdc linked an issue Apr 23, 2026 that may be closed by this pull request
Generate C# marker interfaces for MLIR type interfaces #153
Closed
@jonathanvdc
Changes before error encountered
482e673 
Agent-Logs-Url: https://github.com/jonathanvdc/MLIR.NET/sessions/edba6ac1-505d-40e7-84c5-3e03d7aa3a6f

Co-authored-by: jonathanvdc <9839946+jonathanvdc@users.noreply.github.com>
Copilot AI requested a review from jonathanvdc April 23, 2026 04:05
Copilot AI and others added 2 commits April 23, 2026 14:43
@jonathanvdc
feat(#152): model MLIR interfaces and preserve attr/type trait metada…
773c9ef 
…ta in ODS

Agent-Logs-Url: https://github.com/jonathanvdc/MLIR.NET/sessions/099e21fe-9040-4e07-81eb-144899fcc7da

Co-authored-by: jonathanvdc <9839946+jonathanvdc@users.noreply.github.com>
@jonathanvdc
Changes before error encountered
10fccf1 
Agent-Logs-Url: https://github.com/jonathanvdc/MLIR.NET/sessions/099e21fe-9040-4e07-81eb-144899fcc7da

Co-authored-by: jonathanvdc <9839946+jonathanvdc@users.noreply.github.com>
@jonathanvdc
jonathanvdc marked this pull request as ready for review April 23, 2026 15:49
@jonathanvdc jonathanvdc changed the title [WIP] Fix MLIR interfaces to preserve attr/type trait metadata in ODS Fix MLIR interfaces to preserve attr/type trait metadata in ODS Apr 23, 2026
@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

TableGen Interpreter Benchmarks

Commit: 9f9507f0e56fcdc37023ac81f5918a238e986303

Benchmark Baseline (ms) Candidate (ms) Delta Status
Evaluate.PathologicalDeepClassChain 0.027 0.028 +6.1% Regression
Evaluate.PathologicalListPipeline 0.151 0.155 +2.6% Flat
Evaluate.PreludeArithOps 8.478 8.526 +0.6% Flat
Evaluate.PreludeMiniDialect 3.349 3.342 -0.2% Flat
Evaluate.SimpleInheritanceLets 0.002 0.002 +0.5% Flat
Evaluate.UtilsTd 0.018 0.018 -1.1% Flat
ParseAndEvaluate.PreludeArithOps 20.697 20.663 -0.2% Flat
ParseAndEvaluate.PreludeMiniDialect 9.035 9.091 +0.6% Flat

Interpretation:

  • Regression means candidate mean time is more than 5% slower than baseline.
  • Improvement means candidate mean time is more than 5% faster than baseline.
  • Flat means the change stayed within a 5% noise band.

@jonathanvdc
jonathanvdc merged commit baf908e into main Apr 23, 2026
1 check passed
@jonathanvdc
jonathanvdc deleted the copilot/fix-mlir-type-attr-trait-metadata branch April 23, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanvdc jonathanvdc Awaiting requested review from jonathanvdc

Assignees

@jonathanvdc jonathanvdc

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate C# marker interfaces for MLIR type interfaces Model MLIR interfaces and preserve attr/type trait metadata in ODS

2 participants

@jonathanvdc