Skip to content

Add Brave Browser Nightly to known Chromium browsers for profile support - #554

Merged
johnste merged 1 commit into
johnste:mainfrom
thepaulstella:brave-nightly-profile
Sep 16, 2026
Merged

johnste merged 1 commit into
johnste:mainfrom
thepaulstella:brave-nightly-profile

Conversation

@thepaulstella

@thepaulstella thepaulstella commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Finicky's profile switching (--profile-directory / -n) only works for browsers listed in browsers.json. Brave Browser Nightly (com.brave.Browser.nightly) was missing, so browser: { name: "Brave Browser Nightly", profile: "..." } opened in the default profile.

See #553

Summary by CodeRabbit

  • New Features
    • Added support for detecting and configuring Brave Browser Nightly.
    • Brave Browser Nightly can now be recognized as a Chromium-based browser.

Finicky's profile switching (--profile-directory / -n) only works for
browsers listed in browsers.json. Brave Browser Nightly (com.brave.Browser.nightly)
was missing, so browser: { name: "Brave Browser Nightly", profile: "..." }
silently did nothing.

See johnste#553
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3da04e7b-2f4e-4e00-8cc1-cc5e89e0efba

📥 Commits

Reviewing files that changed from the base of the PR and between a01a9b7 and ac1150e.

📒 Files selected for processing (1)
  • apps/finicky/src/browser/browsers.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Browser configuration

Layer / File(s) Summary
Add Brave Browser Nightly
apps/finicky/src/browser/browsers.json
Adds Brave Browser Nightly with its configuration directory, application ID, Chromium type, and application name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: tdpsk

Merge Risk: ⚪ Minimal · up to ac115

The change adds a narrowly scoped Brave Browser Nightly configuration entry with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Brave Browser Nightly to the known Chromium browsers to support profile switching.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@johnste

johnste commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Thanks!

@johnste
johnste merged commit 4a38875 into johnste:main Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants