Thread limit introspection, part 2: Empirical observation in CI#224
Open
itamarst wants to merge 9 commits into
Open
Thread limit introspection, part 2: Empirical observation in CI#224itamarst wants to merge 9 commits into
itamarst wants to merge 9 commits into
Conversation
…e misleading results
Contributor
Author
|
Looks like occasionally the output is "not sure", but mostly gets everything right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214
In theory one could, say, distribute another package in PyPI/conda-forge of compiled OpenMP code so users can run this locally. Or I guess ... pick some part of e.g. scikit-learn that is unlikely to change but that seems brittle too. So this could be better, and maybe sometime it's worth doing that.
But at least it should run in CI and give us useful info, so it's a good first step.