Repository navigation
84 equilibrium normal shock - #92
Merged
Merged
Conversation
- add methods for computing equilibrium normal shock properties - create equilibrium gas thermo module for computing eq. speed of sound and specific heat ratio - cantera Solution | SolutionArray typealias with docs - good tests (normal shock incomplete though) - add cantera as dependency, matplotlib as optional dependency --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- finished unit test from Huber paper, passed - corrected thermodynamic variable name (isentropic exponent better) --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- add markdown for zensical - update docstrings - add comments about why the mole fraction debacle is the way it is. wait for Scipy 1.19 when find_root gets preserve_shape to simplify this --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 96.00% 96.21% +0.20%
==========================================
Files 21 24 +3
Lines 1704 1957 +253
Branches 75 86 +11
==========================================
+ Hits 1636 1883 +247
- Misses 39 42 +3
- Partials 29 32 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- it's causing problems with find_root, it's EOL anyways --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
--- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- increase coverage (mass frac, speed of sound frozen) - add tests for out of bounds issues --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- fix equation - add references --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- speed_of_sound and lookup_table_by_pressure_temperature now call equilibrate() to ensure states are in equilibrium - lookup_table_by_states does not call equilibrate because it's unknown which properties the user wants to hold constant --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
- add CLI support for p-T and rho-T inputs - add function for calculating via rho-T directly - add necessary bounds checking and regular tests - update docs --- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
--- Signed-off-by: Jared Magnusson <jmag722@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #84