Skip to content

feat: add MinTime and MaxTime helpers #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamMagued wants to merge 1 commit into
base: master
Choose a base branch
from
+191 −0
Open

feat: add MinTime and MaxTime helpers #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ package now

import "time"

// MinTime represents the minimum representable time.Time in Go (-292277022399-01-01 00:00:00 UTC)
var MinTime = time.Date(-292277022399, time.January, 1, 0, 0, 0, 0, time.UTC)

// MaxTime represents the maximum representable time.Time in Go (292277024627-12-06 15:30:07.999999999 UTC)
var MaxTime = time.Unix(1<<63-62135596801, 999999999).UTC()

// WeekStartDay set week start day, default is sunday
var WeekStartDay = time.Sunday

Expand Down Expand Up @@ -197,3 +203,13 @@ func MustParseInLocation(loc *time.Location, strs ...string) time.Time {
func Between(time1, time2 string) bool {
return With(time.Now()).Between(time1, time2)
}

// Min returns the earliest time among the given times
func Min(t1 time.Time, t2 ...time.Time) time.Time {
return With(t1).Min(t2...)
}

// Max returns the latest time among the given times
func Max(t1 time.Time, t2 ...time.Time) time.Time {
return With(t1).Max(t2...)
}
32 changes: 32 additions & 0 deletions now.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,3 +245,35 @@ func (now *Now) Between(begin, end string) bool {
endTime := now.MustParse(end)
return now.After(beginTime) && now.Before(endTime)
}

// Min returns the earliest time among now.Time and the given times
func (now *Now) Min(times ...time.Time) time.Time {
min := now.Time
for _, t := range times {
if t.Before(min) {
min = t
}
}
return min
}

// Max returns the latest time among now.Time and the given times
func (now *Now) Max(times ...time.Time) time.Time {
max := now.Time
for _, t := range times {
if t.After(max) {
max = t
}
}
return max
}

// MinTime returns MinTime
func (now *Now) MinTime() time.Time {
return MinTime
}

// MaxTime returns MaxTime
func (now *Now) MaxTime() time.Time {
return MaxTime
}
143 changes: 143 additions & 0 deletions now_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,149 @@ func TestQuarter(t *testing.T) {
}
}

func TestMinTimeAndMaxTime(t *testing.T) {
if !MinTime.Before(MaxTime) {
t.Fatalf("MinTime should be before MaxTime, got MinTime: %v, MaxTime: %v", MinTime, MaxTime)
}

if !MaxTime.After(MinTime) {
t.Fatalf("MaxTime should be after MinTime, got MinTime: %v, MaxTime: %v", MinTime, MaxTime)
}

testTimes := []time.Time{
time.Time{}, // zero value
time.Unix(0, 0),
time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC),
time.Date(2023, 11, 18, 17, 51, 49, 123456789, time.UTC),
time.Date(100, 5, 10, 12, 0, 0, 0, time.UTC),
time.Date(-1000, 1, 1, 0, 0, 0, 0, time.UTC),
time.Date(9999, 12, 31, 23, 59, 59, 999999999, time.UTC),
time.Date(100000, 1, 1, 0, 0, 0, 0, time.UTC),
timeCaracas,
}

for _, tt := range testTimes {
if !tt.After(MinTime) {
t.Errorf("expected %v to be after MinTime %v", tt, MinTime)
}
if !MinTime.Before(tt) {
t.Errorf("expected MinTime %v to be before %v", MinTime, tt)
}
if !tt.Before(MaxTime) {
t.Errorf("expected %v to be before MaxTime %v", tt, MaxTime)
}
if !MaxTime.After(tt) {
t.Errorf("expected MaxTime %v to be after %v", MaxTime, tt)
}
}

nowInstance := With(time.Now())
if !nowInstance.MinTime().Equal(MinTime) {
t.Errorf("now.MinTime() should equal MinTime")
}
if !nowInstance.MaxTime().Equal(MaxTime) {
t.Errorf("now.MaxTime() should equal MaxTime")
}
}

func TestMin(t *testing.T) {
t1 := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
t2 := time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC)
t3 := time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)

// Single argument
if got := Min(t1); !got.Equal(t1) {
t.Errorf("Min(t1) = %v, expected %v", got, t1)
}

// Two arguments
if got := Min(t1, t2); !got.Equal(t1) {
t.Errorf("Min(t1, t2) = %v, expected %v", got, t1)
}
if got := Min(t2, t1); !got.Equal(t1) {
t.Errorf("Min(t2, t1) = %v, expected %v", got, t1)
}

// Multiple arguments in various orders
if got := Min(t3, t2, t1); !got.Equal(t1) {
t.Errorf("Min(t3, t2, t1) = %v, expected %v", got, t1)
}
if got := Min(t2, t3, t1); !got.Equal(t1) {
t.Errorf("Min(t2, t3, t1) = %v, expected %v", got, t1)
}

// Sentinel boundary pattern
if got := Min(MaxTime, t2, t3); !got.Equal(t2) {
t.Errorf("Min(MaxTime, t2, t3) = %v, expected %v", got, t2)
}
if got := Min(MinTime, t1, t2); !got.Equal(MinTime) {
t.Errorf("Min(MinTime, t1, t2) = %v, expected %v", got, MinTime)
}

// Equal times
t1Copy := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
if got := Min(t1, t1Copy); !got.Equal(t1) {
t.Errorf("Min(t1, t1Copy) = %v, expected %v", got, t1)
}

// Method on Now struct
if got := With(t2).Min(t1); !got.Equal(t1) {
t.Errorf("With(t2).Min(t1) = %v, expected %v", got, t1)
}
if got := With(t1).Min(t2, t3); !got.Equal(t1) {
t.Errorf("With(t1).Min(t2, t3) = %v, expected %v", got, t1)
}
}

func TestMax(t *testing.T) {
t1 := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
t2 := time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC)
t3 := time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)

// Single argument
if got := Max(t1); !got.Equal(t1) {
t.Errorf("Max(t1) = %v, expected %v", got, t1)
}

// Two arguments
if got := Max(t1, t2); !got.Equal(t2) {
t.Errorf("Max(t1, t2) = %v, expected %v", got, t2)
}
if got := Max(t2, t1); !got.Equal(t2) {
t.Errorf("Max(t2, t1) = %v, expected %v", got, t2)
}

// Multiple arguments in various orders
if got := Max(t1, t3, t2); !got.Equal(t3) {
t.Errorf("Max(t1, t3, t2) = %v, expected %v", got, t3)
}
if got := Max(t3, t1, t2); !got.Equal(t3) {
t.Errorf("Max(t3, t1, t2) = %v, expected %v", got, t3)
}

// Sentinel boundary pattern
if got := Max(MinTime, t1, t2); !got.Equal(t2) {
t.Errorf("Max(MinTime, t1, t2) = %v, expected %v", got, t2)
}
if got := Max(MaxTime, t1, t2); !got.Equal(MaxTime) {
t.Errorf("Max(MaxTime, t1, t2) = %v, expected %v", got, MaxTime)
}

// Equal times
t2Copy := time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC)
if got := Max(t2, t2Copy); !got.Equal(t2) {
t.Errorf("Max(t2, t2Copy) = %v, expected %v", got, t2)
}

// Method on Now struct
if got := With(t1).Max(t2); !got.Equal(t2) {
t.Errorf("With(t1).Max(t2) = %v, expected %v", got, t2)
}
if got := With(t3).Max(t1, t2); !got.Equal(t3) {
t.Errorf("With(t3).Max(t1, t2) = %v, expected %v", got, t3)
}
}

func Example() {
time.Now() // 2013-11-18 17:51:49.123456789 Mon

Expand Down