Repository navigation
Conversation
A daylight-saving jump at midnight made time.Date return the previous day, so noon on 2018-11-04 in Sao Paulo began on November 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeginningOfDayof noon on 2018-11-04 in America/Sao_Paulo returned 2018-11-03 23:00. Local midnight did not exist, because the clocks jumped from 23:59 to 01:00, andtime.Dateplaced that missing midnight on the previous day. The day now starts at the first instant that still has that date, 2018-11-04 01:00.An ordinary day in the same zone is still midnight. The Berlin fall-back day already covered by the tests is unchanged, because that midnight exists.
Test plan
go testfor the packageBeginningOfDayformats as2018-11-03 23:00:002018-11-04 01:00:00, and one second earlier is still November 3