Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a timestamp with fractional seconds can silently replace zero hours, minutes and seconds with the reference time. For example, with a reference time of 17:51:49,
2002-10-12T00:00:00.1Zbecomes2002-10-12T17:51:49.1Z. A time-only input such as00:00:00.1can also lose the reference month and day.The time-detection expressions only recognize fractions with 3, 6 or 9 digits. Recognize any fractional precision accepted by the existing time parser, including its comma separator, so explicitly supplied clock components stay intact. Parsing and validation still use the existing layouts and Go's time parser.
Added 80 cases covering fractional precision, zero fractions, UTC and numeric offsets, date-and-time inputs, and time-only inputs. 62 fail before this change. The full test suite and
go vet ./...pass locally on Windows with Go 1.17.13 and 1.27.1. The Ubuntu CI jobs and Go 1.16 have not been run locally.