Repository navigation
fix(node-server): generator-jhipster at 7196a350, the docker:db scripts of SQLite and oauth2AppSchemes of the JDL from JHipster - #1606
Merged
Conversation
mshima
marked this pull request as ready for review
November 3, 2026 13:41
…tes them only for a database of the docker services generator-jhipster at a2666ea7 of main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mshima
force-pushed
the
sqlite-docker-db-scripts
branch
from
November 3, 2026 16:37
3058a98 to
459de3c
Compare
…d of JHipster the server imports generator-jhipster at 7196a350 of main declares oauth2AppSchemes in its docker command: the node-server command imports it, so the JDL of a NodeJS application keeps the URL schemes of its apps, redirect URIs of its Keycloak realm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DanielFran
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generator-jhipster at 7196a350 of main, with two fixes the blueprint takes from it.
The docker:db scripts of SQLite. The docker generator of the blueprint removed the
docker:db:up/docker:db:downscripts for a SQLite production database: JHipster wrote them for any SQL database, without the docker file of its service, sodocker:db:upran adocker compose -f src/main/docker/sqlite.ymlthat does not exist. jhipster/generator-jhipster#35964 writes them only when the database is one of the docker services, like any other database: SQLite gets adocker:db:upthat echoes that docker is not configured for it, and nodocker:db:down.sqliteDatabaseScriptstask of the docker generator is removed.node-serverwithprodDatabaseType: sqlitechecks the echo and that there is nodocker:db:down.oauth2AppSchemes of the JDL.
oauth2AppSchemes, the URL schemes of the apps (like mobile apps) signing in at the OAuth2 provider, was refused by the JDL of a NodeJS application ("Unknown application option: oauth2AppSchemes"): JHipster declared it in its server command, which the server command of the blueprint replaces, so the Keycloak realm got no redirect URI of the apps. jhipster/generator-jhipster#35972 declares it in the docker command of JHipster, the generator writing the realm, which its spring-boot command imports.dockertoo, so the JDL knows the option, without a copy of it in the blueprint.The client snapshot has the two pagination files the client of main now writes (
pagination.ts,pagination.spec.ts).Tested
oauth2AppSchemes [myapp, exp]in its JDL (generated like the jdl command of the cli): the option kept in.yo-rc.json,myapp:*andexp:*among the redirect URIs of the client of the Keycloak realm (docker/realm-config). Without the import ofdocker, the same JDL is refused with "Unknown application option: oauth2AppSchemes".Not tested locally: the CI samples (
monolith-react-sqlite-prod-jdl, and the SQL samples whose scripts now come from the condition of the docker services; none hasoauth2AppSchemes); the CI runs them.🤖 Generated with Claude Code